Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute data to Quote endpoint #141

Closed
lelouchB opened this issue Nov 15, 2020 · 7 comments · Fixed by #142
Closed

Contribute data to Quote endpoint #141

lelouchB opened this issue Nov 15, 2020 · 7 comments · Fixed by #142
Assignees
Labels
backend enhancement New feature or request good first issue Good for newcomers up-for-grabs

Comments

@lelouchB
Copy link
Owner

Contirbute data to quote endpoint.

Make the PR to endpoint branch.

@lelouchB lelouchB added enhancement New feature or request good first issue Good for newcomers up-for-grabs backend labels Nov 15, 2020
@lelouchB lelouchB pinned this issue Nov 15, 2020
@Mayank0255
Copy link
Contributor

@lelouchB I would like to take up this issue and for that I want you to reactify some of my queries as well like what's the process of contributing data to any endpoint as there ain't any CREATE or UPDATE routes, or something else.

@lelouchB
Copy link
Owner Author

@Mayank0255
Sure so this issue is specific for the contributing data to the quote endpoint.

For this issue, you will have to send a PR with different quotes in a JSON format to the endpoint branch.

You can google Final Space quotes and copy the quotes from there and create one quote with indormation as per the schema.
For example

{
quote :"Get Off My Cheeks HUE!",
by:"Gary Goodspeed",
character:"https://finalspaceapi.com/api/v0/character/1",
image:"https://finalspaceapi.com/api/character/avatar/gary_goodspeed.jpg"
}

After around 30 - 50 quotes, I will create more issues on this endpoint.

Are you still interested in this issue?

Hope this answers your question.
Let me know if you have any other question.

@Mayank0255
Copy link
Contributor

@lelouchB I think I am interested in it just two things that in the endpoint branch should I pull from main too or just work with the existing code in endpoint? Secondly this json I can prepare and where do I have to put it? Should I create a Quotes folder and add the json file over there?

@lelouchB
Copy link
Owner Author

lelouchB commented Nov 17, 2020

You can work with the existing code. After the JSON is completed. I will add it to the database so it doesn't matter where you add the JSON in endpoint branch.
Sure, create a quotes folder, if you want.

@Mayank0255
Copy link
Contributor

@lelouchB

Perfect will begin with the json first then create the endpoint. Right?

@lelouchB
Copy link
Owner Author

Yeah
So, Should I assign this to you?

@Mayank0255
Copy link
Contributor

@lelouchB ya please do that

Mayank0255 added a commit to Mayank0255/final-space-api that referenced this issue Nov 17, 2020
@lelouchB lelouchB linked a pull request Nov 17, 2020 that will close this issue
@lelouchB lelouchB unpinned this issue Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request good first issue Good for newcomers up-for-grabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants