Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute data to Location Endpoint #16

Closed
10 tasks done
lelouchB opened this issue Oct 6, 2020 · 9 comments
Closed
10 tasks done

Contribute data to Location Endpoint #16

lelouchB opened this issue Oct 6, 2020 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@lelouchB
Copy link
Owner

lelouchB commented Oct 6, 2020

Reopened to include Season 3 locations

The /location endpoint is currently in progress.

You can contribute data for locations in Final Space in the given schema.

Resource: https://final-space.fandom.com/wiki/Category:Location

P.S. You can leave the field for img_url.

You can send a PR with the data in JSON format to the endpoint branch under location folder.

Here is the schema for /location endpoint:

Key Type Description
id int The id of the location.(Starts with 1)
name string The name of the location.
type array Type of location.
inhabitants string Inhabitants of the location.
notable_residents array Notable residents(if any).
img_url string (url) Image of the location.

(leave fields with no information as Unknown or just empty.)

P.S.: The information about locations is less, so 5-10 main locations data is enough.

This may include but not limited to the following location.

  • Indicates that the data exists for that episode.

  • Earth

  • Final Space

  • Tera Con Prime

  • Inner Space

  • Yarno

  • Dark Zone

  • Deathcropolis

  • Lazarus Trap

  • The Order of the Twelve

@lelouchB lelouchB added enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed labels Oct 6, 2020
@GerryLarios
Copy link

Hello, Can I help with this issue as well?

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 6, 2020

Ofcourse, @GerryLarios

This should be pretty simple as there is not much location information available on the fandom.

I would request you to give every location a read on fandom, they are not that big and will with generating data.

If you have any question or idea about the schema, do let me know.

Thanks, assigning this to you. 👍

@lelouchB lelouchB assigned lelouchB and GerryLarios and unassigned lelouchB Oct 6, 2020
@lelouchB
Copy link
Owner Author

lelouchB commented Oct 8, 2020

@GerryLarios
Any update on this?

Thanks

@GerryLarios
Copy link

@lelouchB working on in, I'll get it done in a few hours.

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 8, 2020

@GerryLarios
Awesome
Looking forward to it.

Have you checked out this
https://finalspaceapi.com/blog/episode

@GerryLarios
Copy link

@lelouchB thanks for the mention! <3

@GerryLarios GerryLarios mentioned this issue Oct 8, 2020
9 tasks
@lelouchB lelouchB closed this as completed Oct 8, 2020
@lelouchB
Copy link
Owner Author

Hey @GerryLarios
https://finalspaceapi.com/blog/location
Its live

@GerryLarios
Copy link

Hey @GerryLarios
https://finalspaceapi.com/blog/location
Its live

Thanks for the mention, looks nice 👍

@lelouchB lelouchB reopened this Jun 30, 2021
@lelouchB
Copy link
Owner Author

Hey @GerryLarios
If interested, please let me know. Else I will re assign this issue to someone else.

Thanks

@lelouchB lelouchB closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants