Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate 300x300 images for location endpoint #97

Closed
lelouchB opened this issue Oct 8, 2020 · 3 comments · Fixed by #117
Closed

Generate 300x300 images for location endpoint #97

lelouchB opened this issue Oct 8, 2020 · 3 comments · Fixed by #117
Assignees
@DmnChzl
Labels
enhancement New feature or request frontend good first issue Good for newcomers hacktoberfest
Projects
v1.0.0

Comments

@lelouchB
Copy link
Owner

lelouchB commented Oct 8, 2020

Following #95 location endpoint will be live soon.

Create images for all the different locations present in #95

Images should be 300x300 jpeg
@lelouchB lelouchB added frontend good first issue Good for newcomers hacktoberfest enhancement New feature or request labels Oct 8, 2020
@lelouchB lelouchB added this to To do in v1.0.0 Oct 8, 2020
@lelouchB lelouchB mentioned this issue Oct 8, 2020
Closed
@lelouchB lelouchB pinned this issue Oct 9, 2020
@DmnChzl
Copy link
Contributor

DmnChzl commented Oct 9, 2020

Hey @lelouchB 👋
I started to work on this part. I already have a set of thumbnails for the 400x300 resolution (the 300px width being too small)... Could this match? 🤔

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 9, 2020

Hey @lelouchB 👋
I started to work on this part. I already have a set of thumbnails for the 400x300 resolution (the 300px width being too small)... Could this match? 🤔

Awesome 👍
400x300 is great too.
I will assign this to you.
Thanks

@lelouchB lelouchB moved this from To do to In progress in v1.0.0 Oct 9, 2020
@lelouchB lelouchB unpinned this issue Oct 9, 2020
@DmnChzl DmnChzl mentioned this issue Oct 9, 2020
Merged
@lelouchB lelouchB linked a pull request Oct 9, 2020 that will close this issue
Added images for location endpoint #117
Merged
@lelouchB lelouchB moved this from In progress to Done in v1.0.0 Oct 9, 2020
@lelouchB lelouchB closed this as completed Oct 9, 2020
@lelouchB
Copy link
Owner Author

Hey @mrdoomy
https://finalspaceapi.com/blog/location
Its live

@lelouchB lelouchB moved this from Done to Shipped to Production in v1.0.0 Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmnChzl DmnChzl

Labels
enhancement New feature or request frontend good first issue Good for newcomers hacktoberfest
Projects
v1.0.0
Shipped to Production
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added images for location endpoint
2 participants
@DmnChzl @lelouchB