Skip to content

[ADD] episode's data season 1 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GerryLarios
Copy link

Episode's data

  • Chapter 1
  • Chapter 2
  • Chapter 3
  • Chapter 4
  • Chapter 5
  • Chapter 6
  • Chapter 7
  • Chapter 8
  • Chapter 9
  • Chapter 10
  • The Toro Regatta
  • The Happy Place
  • The Grand Surrender
  • The Other Side
  • The Notorious Mrs. Goodspeed
  • The Arachnitects
  • The First Times They Met
  • The Remembered
  • The Closer You Get
  • The Lost Spy
  • The Set Up
  • The Descent Into Darkness
  • The Sixth Key

@lelouchB lelouchB linked an issue Oct 6, 2020 that may be closed by this pull request
24 tasks
@lelouchB
Copy link
Owner

lelouchB commented Oct 6, 2020

Hey @GerryLarios
Great work

It looks awesome, just a small thing instead of character's name, I would appreciate if you add the link to their individual API link

For e.g. For Gar Goodspeed the link would be https://finalspaceapi.com/api/v0/character/1

Thanks 👍

@GerryLarios
Copy link
Author

@lelouchB fixed, by the by, I only put the first season, but I will finish all the episodes. 👍

@lelouchB lelouchB merged commit 6b67c47 into lelouchB:endpoint Oct 7, 2020
@GerryLarios
Copy link
Author

GerryLarios commented Oct 15, 2020

@lelouchB Sorry to ask, but can you add the label hacktoberfest-accepted to my PR?

@lelouchB
Copy link
Owner

I have added Hacktoberfest label to the repo and this PR is merged so it should work for Hacktoberfest.

But I will also add Hacktoberfest label 🏷

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribute data to Episode endpoint
2 participants