Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 15 images for new chars #26 #40

Merged
merged 19 commits into from Oct 7, 2020
Merged

add 15 images for new chars #26 #40

merged 19 commits into from Oct 7, 2020

Conversation

mowens86
Copy link

@mowens86 mowens86 commented Oct 7, 2020

Here we are. Let me know if this works for you. The toughest one quality-wise was the blade.

Your Name and others added 19 commits October 5, 2020 18:24
broke index.js into smaller components
e043ed6
fixed pages
953186c
fixed routes
bbdd2ff
@AldoTu
Changed jpg images to WebP format
aeb47a7
@lelouchB
Merge pull request lelouchB#19 from AldoTu/main
3f93272 
Changed jpg images to WebP format
@lelouchB
Update README.md
7c1b2d4
@lelouchB
Update about.md
5b90d76
@lelouchB
Update about.md
5a72471
@lelouchB
Updated package.json
b1b4164
@lelouchB
Merge branch 'main' of https://github.com/lelouchB/final-space-api in…
fe4af4b 
…to main
@Pervolarakis
updated _card.js
2b6243a
added parent directory
9132f09
@Pervolarakis
Merge branch 'main' into routesfinal
2ecea79
@lelouchB
Merge pull request lelouchB#14 from Pervolarakis/routesfinal
bf4d79b 
Refactored frontend/src/pages/index.js
@lelouchB
removing empty folder
e3ccde3
@lelouchB
removing unused imports
4d7df8d
@lelouchB
Update README.md
270a5ad
@Skr-suyash
Added README for backend (lelouchB#22)
9a4f0d6 
* Added README for backend

* Updated README with few changes

* Added correct image and few more changes

* Added readme to correct place
@mowens86
add 15 images for new chars lelouchB#26
c220af0
@lelouchB lelouchB self-requested a review October 7, 2020 03:23
@lelouchB lelouchB linked an issue Oct 7, 2020 that may be closed by this pull request
Add 300x300px jpeg Images for new Characters #26
Closed
@lelouchB
Copy link
Owner

lelouchB commented Oct 7, 2020

@mowens86
Amazing work 👏
I am going through each image, will let you know if there is any modifications required. I don’t think it will.

I would like if you make this PR to endpoint branch instead.

Thanks

@lelouchB
Copy link
Owner

lelouchB commented Oct 7, 2020

@mowens86
Everything is fine with me.
Thanks
If you want, you can take a look at #3

There are some images that I have mentioned in the comments that need some work.
If you can help generate those images as well it will be really helpful.

P.S. only the images that I have mentioned in comments in #15 most of the images are fine,there are a few that needs work.

Also , I will be creating an issues for images for episode endpoint as well
Let me know if you are interested in that as well.

Again, amazing work

@mowens86 mowens86 closed this Oct 7, 2020
@mowens86 mowens86 reopened this Oct 7, 2020
@mowens86 mowens86 changed the base branch from main to endpoint October 7, 2020 03:59
@lgtm-com
Copy link

lgtm-com bot commented Oct 7, 2020

This pull request fixes 2 alerts when merging c220af0 into 5d9e36b - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@lelouchB lelouchB merged commit 5dad1d0 into lelouchB:endpoint Oct 7, 2020
@lelouchB
Copy link
Owner

lelouchB commented Oct 7, 2020

@mowens86
The new characters are live
Here is the blog for this https://finalspaceapi.com/blog/15characters

Try them here https://finalspaceapi.com/api/v0/character

Thanks for your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lelouchB lelouchB lelouchB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 300x300px jpeg Images for new Characters
5 participants
@mowens86 @lelouchB @AldoTu @Pervolarakis @Skr-suyash