Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] 9 locations #95

Merged
merged 3 commits into from Oct 8, 2020
Merged

[ADD] 9 locations #95

merged 3 commits into from Oct 8, 2020

Conversation

GerryLarios
Copy link

#16

  • Earth
  • Final Space
  • Tera Con Prime
  • Inner Space
  • Yarno
  • Dark Zone
  • Deathcropolis
  • Lazarus Trap
  • The Order of the Twelve

@GerryLarios
Copy link
Author

@lelouchB here is the PR. Let me know if we need to change something.

lelouchB
lelouchB requested changes Oct 8, 2020
View reviewed changes
Copy link
Owner

@lelouchB lelouchB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This great
Obviously the data is less as compared to others.
No worries about that.

Just replace the URL in img_url to empty quotes.

I will create a separate issue for images of the locations

Let me know if you would be interested in that?
Thanks 😊

@GerryLarios
Copy link
Author

@lelouchB comments addressed. About the image, let me check how can I work with that 👁️

@lelouchB
Copy link
Owner

lelouchB commented Oct 8, 2020

@GerryLarios
I will let you know when this goes live

Thanks for your amazing work

@lelouchB lelouchB merged commit 590b53d into lelouchB:endpoint Oct 8, 2020
This was referenced Oct 8, 2020
Closed
Closed
@GerryLarios
Copy link
Author

Hello @lelouchB Can you add the label hacktoberfest-accepted to my PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lelouchB lelouchB lelouchB approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GerryLarios @lelouchB