Permalink
Switch branches/tags
Nothing to show
Commits on May 24, 2015
  1. bup.helper: Follow the same style wrt "while; do" everywhere

    lelutin committed May 24, 2015
    changing style within a program is considered a bad practice since it
    makes the code harder to maintain.
  2. rdiff handler: rename get_version to rdiff_version

    lelutin committed May 24, 2015
    This'll make things more consistent with how the bup handler does
    things. The new function name makes it a lot clearer what is happening,
    and also helps prevent function scope collisions.
  3. avoid using asterisks in default includes

    lelutin committed Nov 13, 2014
    bup doesn't do file name globbing by itself for "included" paths. we
    need to manually specify all possibilities. Luckily these are quite
    simple to list.
  4. debug for commands missing -d argument

    lelutin committed Nov 13, 2014
    oops, when -d '$remote_bupdir' was added to select the remote repository
    path with "on"-type backups, the debugging string that shows the
    commands being run wasn't adapted.
  5. bup gets paths with a single quote in them

    lelutin committed Nov 13, 2014
    well this was a weird bash typical headache. without using a second
    layer of shell, the quotes are useless and are passed in to bup with the
    paths themselves.
  6. be more careful when accumulating variables that can contain regexes

    lelutin committed Nov 13, 2014
    This is especially useful for exclude_rx_list
  7. set default value for remote_bupdir if variable is empty

    lelutin committed Nov 13, 2014
    Without this, we could encounter weird situations where the code that
    tries to initiate the remote bupdir runs "mkdir -p" without any path.
  8. fixup: missing "then"

    lelutin committed Nov 9, 2014
  9. bup.helper.in: weird comment format

    lelutin committed Sep 28, 2013
    a user-error with vim's auto formatting left out a weird form of
    comments. we don't want those extra hash signs.
  10. bup.helper.in: some titles are not clear enough

    lelutin committed Sep 28, 2013
    try and be more descriptive about what data should be typed in each
    step.
  11. bup.in: respect backupninja style for caps

    lelutin committed Sep 28, 2013
    don't use caps for non-global variables, or variables that require to be
    named with caps.
  12. bup.in: show versions in error message when they don't match

    lelutin committed Sep 28, 2013
    also don't call bup to get the localversion when we're not going to
    compare it to the remote version.
  13. bup.in: move variable creation in EXEC section for better readability

    lelutin committed Sep 28, 2013
    This make the CHECK CONFIG section stand out more, and also brings
    variables that are constructed with configuration closer to where they
    are used.
    
    It's also more sane that way since once we start building those
    variables we've completed sanity checking.
  14. bup.in: make user and host confifs mandatory for non-local backups

    lelutin committed Sep 28, 2013
    If we leave out the user name in the ssh commands, that means that the
    handler is influenced by the contents of elements external to the
    configuration in backup.d . that might mean that clearing off the
    required part in ~/.ssh/config might break backup runs
  15. bup.in: correctly quote includes and excludes

    lelutin committed Sep 28, 2013
    this will make it so that people can use spaces in the paths without
    having to think about escaping the spaces.
    
    this was imported from the rdiff handler and simplified.
  16. bup.in: rename version function

    lelutin committed Sep 28, 2013
    let's avoid namespace collisions and use a name that's better
    descriptive to the local context of the bup handler.
  17. Style corrections around ssh lib

    lelutin committed Sep 28, 2013
    respect lexical ordering in files that include this lib.
    
    shorten tests for ssh_create_root_key and ssh_ensure_remote_dir
  18. bup.helper: fallback to calling remote bup from path

    lelutin committed Sep 23, 2013
    since we cannot garanty that bup will be called with the path that we'd
    like to on the remote end, we need to fallback to expecting it to be in
    the PATH.
  19. use $BUP locally, but not remotely.

    lelutin committed Sep 23, 2013
    since we cannot garanty that a certain path will be used for the remote
    bup (commands will call bup by themselves on the remote host and won't
    let us specify the path), we need to fallback to expecting bup to be in
    the PATH on the remote server.
    
    but locally, we can garanty where the binary will be called from so
    let's honour that
  20. get testconnect option

    lelutin committed Sep 23, 2013
  21. bup.in: don't execute anything if in test mode

    lelutin committed Sep 23, 2013
    backupninja -t is supposed to only test that connections work so let's
    honour that option.
    
    while we're at it, make all indentation 3-spaces-wide. as much as I hate
    3-space-wide indentation, it's used by all other helpers so we should
    probably match the same style as the other scripts.
  22. bup.helper: add more details to the generated config files

    lelutin committed Sep 23, 2013
    let's be more helpful to people when they generate config files so that
    they can understand what's doing what.