Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Expect vs Should syntax #83
Ah! I think what is confusing in the contexts example is that, when going from BAD to GOOD, not only is the context added but the "it" is changed to a one-liner which also makes the "expect" become a "should". It seems like the only changes from a BAD example to a GOOD example should be directly related to the particular guideline being illustrated for maximum clarity ;)
Also adding a note to the Expect vs. Should guideline about the one-line format still (acceptably) using should might be helpful.
I found a minor typo on Expect vs. Should too: "Configure the Rspec to only accept the new syntax on new projects, to avoid have the 2 syntax all over the place." (the "have" should be a "having").
Let me know if I should create a pull request or new issue for these :)
I agree that
I think both syntaxes for one-liners should be on the "GOOD" list.