Compute quickly the byte lengths without look-ups #12

Open
lemire opened this Issue Nov 7, 2017 · 5 comments

Comments

Projects
None yet
3 participants
Owner

lemire commented Nov 7, 2017

Some look-ups could be efficiently replaced by fast instructions such as a pdep followed by a multiplication and a shift. It is unlikely to be generally faster than a look-up, but it might be worth exploring.

Collaborator

KWillets commented Nov 7, 2017

The length is 1 + the rightmost index in the decoding shuffle, which is within the last four entries.

lemire added a commit that referenced this issue Nov 7, 2017

Owner

lemire commented Nov 7, 2017

As per this commit dac1b23 , @KWillets's approach can be enabled by defining a macro. I am concerned about making this a default without enough hard numbers.

Note that I have ported the approach to neon (it was trivial).

Contributor

aqrit commented Nov 23, 2017

// is mod15 faster than pdep?
len = ((key * 0x0401 & 0x00033033) % 0x0F) + 4; 

// simd
v = ((v >> 2) & 0x33333333) + (v & 0x33333333);
v = ((v >> 4) & 0x0F0F0F0F) + (v & 0x0F0F0F0F);
len4 = v + 0x04040404;
// todo: now extract each byte...
Collaborator

KWillets commented Nov 23, 2017

It is definitely susceptible to various bithacks. I used the permutation table since it's available, but the 2-bit fields could also be summed in a few instructions.

mod15 compiles to a multiply and some shifts and subtracts, so it may be decomposable into fewer instructions in this context.

Generally I would spread the bitfields out and use a multiply to sum them into something like the most significant byte; that's what I do in the compressor when I have the 2-bit fields already spread out. Your method of multiplying by 0x401 and masking looks promising -- they're far enough apart to sum into a nybble at that point. Multiplying by (1<<28)|(1<<24)|(1<<16)|(1<<12) should drop them on top of each other in the high nybble, if I've got those shifts right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment