Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_entries(sort='recent') "denial of service" #305

Open
lemon24 opened this issue May 15, 2023 · 3 comments
Open

get_entries(sort='recent') "denial of service" #305

lemon24 opened this issue May 15, 2023 · 3 comments

Comments

@lemon24
Copy link
Owner

lemon24 commented May 15, 2023

The new heuristic from #279 is too lax, if a feed adds all lots of new entries, it can spam the top of "recent"; this should not be possible.

Background: https://www.michaelnygard.com/atom.xml in my personal instance just added 60+ (years) old entries; for now I marked everything as read, so the added time is preserved for debugging.

Possible solutions:

@lemon24
Copy link
Owner Author

lemon24 commented Aug 25, 2023

Another one(?) – 15 https://scattered-thoughts.net/atom.xml entries from the last ~2 years just appeared in my feed; these may be duplicates (if so, entry_dedupe should copy the old recent sort key, if it doesn't already).

Update: Nope, they were "new" entries (not duplicates); also, entry_dedupe already handles the recent sort key.

@lemon24
Copy link
Owner Author

lemon24 commented Mar 16, 2024

http://yosefk.com/blog/feed switched feed generators a few days ago, and I got 7 8-year-old entries in recent. I believe the root cause is the same (new feed has more entries than the old one).

Update: I checked, and this is indeed the root cause.

@lemon24
Copy link
Owner Author

lemon24 commented May 26, 2024

Another one, with hundreds of entries: https://blog.startifact.com/rss.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant