Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Coverage went from 46% to 89% in a single commit #28

Closed
skwp opened this Issue Mar 29, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Owner

nickmerwin commented Mar 29, 2013

Hi @skwp, yesterday we started ignoring coverage data for source files in the vendor directory. Those files shouldn't be included in test coverage to begin with, but it's not clear that you would have you manually filter them out like so:

Coveralls.wear! do
  add_filter 'vendor'
end

Your repo's relavent lines dropped from 24K to <1K since all of your vendored gems were being analyzed.

I'll kick off a process that will go through your old builds and remove those files to smooth out the coverage chart.

Closing for now, please open if you have more questions / concerns.

Thank you!

@nickmerwin nickmerwin closed this Mar 29, 2013

skwp commented Apr 1, 2013

Thanks this is great, wish it was communicated better up front :)

yan

On Mar 29, 2013, at 5:06 PM, Nick Merwin notifications@github.com wrote:

Hi @skwp, yesterday we started ignoring coverage data for source files in the vendor directory. Those files shouldn't be included in test coverage to begin with, but it's not clear that you would have you manually filter them out like so:

Coveralls.wear! do
add_filter 'vendor'
end
Your repo's relavent lines dropped from 24K to <1K since all of your vendored gems were being analyzed.

I'll kick off a process that will go through your old builds and remove those files to smooth out the coverage chart.

Closing for now, please open if you have more questions / concerns.

Thank you!


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment