Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings #21

Merged
merged 2 commits into from
Sep 18, 2013
Merged

Conversation

steveklabnik
Copy link
Contributor

coveralls currently throws a few warnings when I run it with my test suite. These commits remove them.

The second commit might be tackled another way, but the extend self makes it really confusing if you're on a module level or not. Like, I think I could just set the class variables inside of setup!, but I'm not 100% sure, and this seemed clearer.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 12d0e39 on steveklabnik:remove_warnings into 62cf552 on lemurheavy:master.

@nickmerwin nickmerwin merged commit 12d0e39 into lemurheavy:master Sep 18, 2013
@nickmerwin
Copy link
Member

Thanks @steveklabnik !

@steveklabnik
Copy link
Contributor Author

Any time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants