Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Port to Qt 5. #29
Conversation
yuyichao
reviewed
Mar 4, 2015
| @@ -20,9 +20,7 @@ | ||
| #ifndef __CANDIDATE_WORD_H__ | ||
| #define __CANDIDATE_WORD_H__ | ||
| -#include <QDeclarativeView> | ||
| -#include <QObject> | ||
| -#include <qdeclarative.h> |
attente
Mar 4, 2015
Contributor
Is there a reason or a link that explains why? I can fix it, but don't know why it's preferred.
attente
Mar 4, 2015
Contributor
Ok, looking around, I see that it seems to make some projects compile a lot slower. I'll fix this, thanks.
yuyichao
Mar 4, 2015
That's also my guess. I remember seeing it somewhere in a porting guide but could not find it anymore. It also makes it easier to support both Qt4 and Qt5.
added a commit
that referenced
this pull request
Mar 5, 2015
lenky0401
merged commit 05fd858
into
lenky0401:master
Mar 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
attente commentedMar 2, 2015
Port fcitx-qimpanel to Qt 5. We need this because Qt 4 isn't supported by Mir.