Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build status #451

Merged
merged 17 commits into from
Sep 28, 2023
Merged

fix: build status #451

merged 17 commits into from
Sep 28, 2023

Conversation

pichoemr
Copy link
Contributor

@pichoemr pichoemr commented Sep 12, 2023

About this PR

Closes #

Technical highlight/advice

How to test my changes

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

shiipou
shiipou previously approved these changes Sep 22, 2023
@shiipou
Copy link
Contributor

shiipou commented Sep 22, 2023

@pichoemr You must resolve the conflict and then you can squash merge it.

taorepoara
taorepoara previously approved these changes Sep 27, 2023
Copy link
Member

@taorepoara taorepoara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Have try it ?

@pichoemr
Copy link
Contributor Author

Seems OK. Have try it ?

Yes we test it in staging

@taorepoara taorepoara merged commit ebceb27 into beta Sep 28, 2023
4 checks passed
@taorepoara taorepoara deleted the fix-build-status branch September 28, 2023 07:22
@taorepoara
Copy link
Member

🎉 This PR is included in version 1.0.0-beta.168 🎉

The release is available on:

Your semantic-release bot 📦🚀

@taorepoara
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Check pod status instead of waiting for completion notification when using kubernetes pipeline runner
3 participants