Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Menu component memory leak #6526

Merged
merged 1 commit into from Nov 7, 2022
Merged

Conversation

aleksfront
Copy link
Contributor

Fixing growing memory consumption by adding missing removeEventListener lines for the Menu instances.

Fixes #6518

Signed-off-by: Alex Andreev alex.andreev.email@gmail.com

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront added bug Something isn't working area/ui labels Nov 7, 2022
@aleksfront aleksfront added this to the 6.1.16 milestone Nov 7, 2022
@aleksfront aleksfront requested a review from a team as a code owner November 7, 2022 14:04
@aleksfront aleksfront requested review from jansav and Iku-turso and removed request for a team November 7, 2022 14:04
Copy link
Contributor

@Iku-turso Iku-turso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying design could use some love, but approved still :)

@Nokel81 Nokel81 merged commit 82ab60d into master Nov 7, 2022
@Nokel81 Nokel81 deleted the fix-menu-component-memory-leak branch November 7, 2022 14:54
Nokel81 pushed a commit that referenced this pull request Nov 7, 2022
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@Nokel81 Nokel81 mentioned this pull request Nov 7, 2022
Nokel81 added a commit that referenced this pull request Nov 7, 2022
* Release 6.1.16

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix for Menu component memory leak (#6526)

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Co-authored-by: Alex Andreev <alex.andreev.email@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lens hogs a ton of memory and the cluster webview crashes / hangs
3 participants