feature: allowing FLUTTER_GIT_URL to be the default value of flutterUrl #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Flutter project reports a warning to users who replace the standard GitHub location of Flutter with their own. They also provide an environment variable (`FLUTTER_GIT_URL`) which can be set by the user to indicate that this is intentional. FVM provides a similar feature to override the GIT location from which the Flutter install will be cloned, and it is implemented as the command-line parameter `--flutterUrl`. Defaulting to using the environment variable defined by Flutter as the value of `flutterUrl`, provides most corporations that host their own repository with a seamless use of the `fvm` tool without requiring all developers to include the `--flutterUrl` parameter manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flutter project reports a warning to users who replace the standard GitHub location of Flutter with their own. They also provide an environment variable (
FLUTTER_GIT_URL) which can be set by the user to indicate that this is intentional.FVM provides a similar feature to override the GIT location from which the Flutter install will be cloned, and it is implemented as the command-line parameter
--flutterUrl.Defaulting to using the environment variable defined by Flutter as the value of
flutterUrl, provides most corporations that host their own repository with a seamless use of thefvmtool without requiring all developers to include the--flutterUrlparameter manually.