Added legacy config #631
Added legacy config #631
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DCM report✅ no issues found! Full report: https://github.com/leoafarias/fvm/runs/21686580477 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
==========================================
- Coverage 62.63% 61.99% -0.64%
==========================================
Files 50 50
Lines 1908 1921 +13
==========================================
- Hits 1195 1191 -4
- Misses 713 730 +17 ☔ View full report in Codecov by Sentry. |
| // Used for migration of config files | ||
| final legacyConfig = ProjectConfig.loadFromPath(legacyConfigFile); | ||
|
|
||
| if (legacyConfig != null) { | ||
| if (config == null && legacyConfig != null) { | ||
| legacyConfig.save(configFile); |
There was a problem hiding this comment.
Does this need to load the new config?
There was a problem hiding this comment.
Yes, this is the migration of the new config that does not exist. It creates a new one based on the old one.
There was a problem hiding this comment.
Yes, but config is still null right, doesn't it need to be loaded after migration?
Generates legacy fvm_config.json file to better support tools that need to migrate