From 55cfdd99633f1408193dc3a83c5f2b2d9122d983 Mon Sep 17 00:00:00 2001 From: Caleb Donovick Date: Mon, 10 Dec 2018 17:35:30 -0800 Subject: [PATCH 1/2] Don't materialize list --- silica/ast_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/silica/ast_utils.py b/silica/ast_utils.py index d89cb4f..1fb2ec8 100644 --- a/silica/ast_utils.py +++ b/silica/ast_utils.py @@ -39,7 +39,7 @@ def f(node): setattr(module_obj, "is_" + to_camel_case(name), f) -for x in [m[0] for m in inspect.getmembers(ast, inspect.isclass) if m[1].__module__ == '_ast']: +for x in (m[0] for m in inspect.getmembers(ast, inspect.isclass) if m[1].__module__ == '_ast'): is_generator(x) From 5a648d3607fa822aacb35539746d76f042f0d985 Mon Sep 17 00:00:00 2001 From: Caleb Donovick Date: Mon, 10 Dec 2018 17:36:37 -0800 Subject: [PATCH 2/2] Name function correctly --- silica/ast_utils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/silica/ast_utils.py b/silica/ast_utils.py index 1fb2ec8..98ca1a8 100644 --- a/silica/ast_utils.py +++ b/silica/ast_utils.py @@ -25,8 +25,8 @@ def get_ast(obj): _first_cap_re=re.compile(r'(.)([A-Z][a-z]+)') _all_cap_re=re.compile(r'([a-z0-9])([A-Z])') -def to_camel_case(name): - """ Converts name from SnakeCase to camel_case +def to_snake_case(name): + """ Converts name from CamelCase to snake_case https://stackoverflow.com/questions/1175208/elegant-python-function-to-convert-camelcase-to-snake-case """ @@ -37,7 +37,7 @@ def is_generator(name): def f(node): return isinstance(node, getattr(ast, name)) - setattr(module_obj, "is_" + to_camel_case(name), f) + setattr(module_obj, "is_" + to_snake_case(name), f) for x in (m[0] for m in inspect.getmembers(ast, inspect.isclass) if m[1].__module__ == '_ast'): is_generator(x)