Refactor/3.x #2
Merged
Refactor/3.x #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge #1 before this. |
leonelgalan
force-pushed
the
refactor/3.x
branch
2 times, most recently
from
83e3cab
to
0ea5fb2
Compare
- Matches the namespace used by the latest _https://github.com/aws/aws-sdk-ruby_, this improvement was proposed by @tennantje on 58bits/cloudfront-signer#5 - Adds missing `s` to `options`. Fixes unreported bug when using ip_range to build a custom policy.
* Renames sign to `build_url`. For better semantics, build_url builds a URL using `signed_params`, but is not concerned with signing.
|
Congrats and thank you for the new version, the updates, and the new ownership of this gem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.