Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/3.x #2

Merged
merged 3 commits into from May 18, 2015
Merged

Refactor/3.x #2

merged 3 commits into from May 18, 2015

Conversation

@leonelgalan
Copy link
Owner

@leonelgalan leonelgalan commented May 14, 2015

No description provided.

@leonelgalan
Copy link
Owner Author

@leonelgalan leonelgalan commented May 14, 2015

Merge #1 before this.

@leonelgalan leonelgalan force-pushed the refactor/3.x branch 2 times, most recently from 83e3cab to 0ea5fb2 May 18, 2015
leonelgalan added 3 commits May 14, 2015
- Matches the namespace used by the latest
_https://github.com/aws/aws-sdk-ruby_, this improvement was proposed by
@tennantje on 58bits/cloudfront-signer#5
- Adds missing `s` to `options`. Fixes unreported bug when using ip_range to build a custom policy.
* Renames sign to `build_url`. For better semantics, build_url builds a
URL using `signed_params`, but is not concerned with signing.
@leonelgalan leonelgalan force-pushed the refactor/3.x branch from 0ea5fb2 to 289491e May 18, 2015
@leonelgalan

This comment has been minimized.

Copy link
Owner Author

@leonelgalan leonelgalan commented on lib/cloudfront-signer.rb in 18b19cc May 18, 2015

TODO: Apply this same fix to 2.x

leonelgalan pushed a commit that referenced this pull request May 18, 2015
Refactor/3.x
@leonelgalan leonelgalan merged commit fb3dc35 into master May 18, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@leonelgalan leonelgalan deleted the refactor/3.x branch May 18, 2015
@tennantje
Copy link

@tennantje tennantje commented May 19, 2015

Congrats and thank you for the new version, the updates, and the new ownership of this gem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants