Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
option to adjust documentElement #821
I've had a great problem with the noUiSlider when using it inside of an Off-Canvas component (foundation-sites framework) with the option
After digging through the noUiSlider sources I've found out the reason:
To fix this you have to change
That's why I've made this PR which provides an option to adjust it.
@leongersen would you please review and merge if it's ok for you?
Sorry I never got back to this! I am not sure about an option to replace the document element, as a lot of events (e.g.
@leongersen the new option does not affect any existing project and is meant to be used in cases where the default documentElement does not work (e.g. when using the Off-Canvas plugin of the Foundation framework as mentioned above).
Here's a simple codepen to show the problem and how it's fixed using the new option.
I've merged dev into my feature branch so my PR is (again) ready to merge.
Any comment from you beside the link would be helpful.
The mentioned 'bugfix' on stackoverflow is no fix because the option in talk (
The only solution so far is the additional option, introduced by this PR.