Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: github issue forms #51

Merged
merged 5 commits into from Aug 24, 2022
Merged

Conversation

leonsteinhaeuser
Copy link
Owner

This PR removes Markdown issue templates and adds GitHub issue forms.

Closes: #48

@leonsteinhaeuser leonsteinhaeuser self-assigned this Aug 19, 2022
@leonsteinhaeuser leonsteinhaeuser added the size/S Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2022
@leonsteinhaeuser leonsteinhaeuser changed the title feature: github issue form feature: github issue forms Aug 19, 2022
Copy link
Contributor

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! however adding questions issue might be confusing over Q&A in discussions tab. i'd suggest adding a link to guide them to discussions.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/question.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
leonsteinhaeuser and others added 3 commits August 23, 2022 21:56
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Copy link
Contributor

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!
maybe could you also remove .github/ISSUE_TEMPLATE/question.yml before merging since now it's empty?

@leonsteinhaeuser
Copy link
Owner Author

great! maybe could you also remove .github/ISSUE_TEMPLATE/question.yml before merging since now it's empty?

That makes sense. I used the GitHub merge buttons and it seems that one of the changes did not delete the question template. I have now done this by hand.

@scarf005
Copy link
Contributor

At least 1 approving review is required by reviewers with write access.

since my review approval doesn't count (no write access), you could safely merge with administer rights .

@leonsteinhaeuser leonsteinhaeuser merged commit 6b189ed into main Aug 24, 2022
1 check passed
@leonsteinhaeuser leonsteinhaeuser deleted the feature/github-issue-form branch August 24, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature size/S Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

[Feature Request] Update to issue form
2 participants