Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: positive actions state on error call #54

Merged
merged 1 commit into from Sep 24, 2022

Conversation

leonsteinhaeuser
Copy link
Owner

@leonsteinhaeuser leonsteinhaeuser commented Sep 24, 2022

This PR fixes a problem that occurs when the underlying call fails and the action was marked as positive.

Fixes: #53

failure_call

@leonsteinhaeuser leonsteinhaeuser self-assigned this Sep 24, 2022
@leonsteinhaeuser leonsteinhaeuser added the size/XS Denotes a PR that changes 0-99 lines, ignoring generated files. label Sep 24, 2022
@leonsteinhaeuser leonsteinhaeuser marked this pull request as ready for review September 24, 2022 11:50
@leonsteinhaeuser leonsteinhaeuser merged commit b0f7d64 into main Sep 24, 2022
3 checks passed
@leonsteinhaeuser leonsteinhaeuser deleted the fix/positive-actions-on-error-call branch September 24, 2022 11:52
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Oct 1, 2022
…to v2.0.1 (#2172)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [leonsteinhaeuser/project-beta-automations](https://togithub.com/leonsteinhaeuser/project-beta-automations) | action | patch | `v2.0.0` -> `v2.0.1` |

---

### Release Notes

<details>
<summary>leonsteinhaeuser/project-beta-automations</summary>

### [`v2.0.1`](https://togithub.com/leonsteinhaeuser/project-beta-automations/releases/tag/v2.0.1)

[Compare Source](https://togithub.com/leonsteinhaeuser/project-beta-automations/compare/v2.0.0...v2.0.1)

#### What's Changed

-   fix: positive actions state on error call by [@&#8203;leonsteinhaeuser](https://togithub.com/leonsteinhaeuser) in [leonsteinhaeuser/project-beta-automations#54

**Full Changelog**: leonsteinhaeuser/project-beta-automations@v2.0.0...v2.0.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODUuMyIsInVwZGF0ZWRJblZlciI6IjMyLjE4NS4zIn0=-->
kodiakhq bot pushed a commit to cloudquery/helm-charts that referenced this pull request Oct 1, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [helm/chart-releaser-action](https://togithub.com/helm/chart-releaser-action) | action | patch | `v1.4.0` -> `v1.4.1` |
| [helm/chart-testing-action](https://togithub.com/helm/chart-testing-action) | action | patch | `v2.3.0` -> `v2.3.1` |
| [leonsteinhaeuser/project-beta-automations](https://togithub.com/leonsteinhaeuser/project-beta-automations) | action | patch | `v2.0.0` -> `v2.0.1` |

---

### Release Notes

<details>
<summary>helm/chart-releaser-action</summary>

### [`v1.4.1`](https://togithub.com/helm/chart-releaser-action/releases/tag/v1.4.1)

[Compare Source](https://togithub.com/helm/chart-releaser-action/compare/v1.4.0...v1.4.1)

#### What's Changed

-   document required permissions by [@&#8203;davidkarlsen](https://togithub.com/davidkarlsen) in [helm/chart-releaser-action#114
-   bump cr to v1.4.1 by [@&#8203;cpanato](https://togithub.com/cpanato) in [helm/chart-releaser-action#121

**Full Changelog**: helm/chart-releaser-action@v1.4.0...v1.4.1

</details>

<details>
<summary>helm/chart-testing-action</summary>

### [`v2.3.1`](https://togithub.com/helm/chart-testing-action/releases/tag/v2.3.1)

[Compare Source](https://togithub.com/helm/chart-testing-action/compare/v2.3.0...v2.3.1)

#### What's Changed

-   bump ct to v3.7.1 by [@&#8203;cpanato](https://togithub.com/cpanato) in [helm/chart-testing-action#96

**Full Changelog**: helm/chart-testing-action@v2.3.0...v2.3.1

</details>

<details>
<summary>leonsteinhaeuser/project-beta-automations</summary>

### [`v2.0.1`](https://togithub.com/leonsteinhaeuser/project-beta-automations/releases/tag/v2.0.1)

[Compare Source](https://togithub.com/leonsteinhaeuser/project-beta-automations/compare/v2.0.0...v2.0.1)

#### What's Changed

-   fix: positive actions state on error call by [@&#8203;leonsteinhaeuser](https://togithub.com/leonsteinhaeuser) in [leonsteinhaeuser/project-beta-automations#54

**Full Changelog**: leonsteinhaeuser/project-beta-automations@v2.0.0...v2.0.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODUuMyIsInVwZGF0ZWRJblZlciI6IjMyLjE4NS4zIn0=-->
kodiakhq bot pushed a commit to cloudquery/plugin-sdk that referenced this pull request Oct 3, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [leonsteinhaeuser/project-beta-automations](https://togithub.com/leonsteinhaeuser/project-beta-automations) | action | patch | `v2.0.0` -> `v2.0.1` |
| [nosborn/github-action-markdown-cli](https://togithub.com/nosborn/github-action-markdown-cli) | action | minor | `v3.0.1` -> `v3.2.0` |
| tubone24/update_release | action | digest | `d6c9168` -> `9961190` |

---

### Release Notes

<details>
<summary>leonsteinhaeuser/project-beta-automations</summary>

### [`v2.0.1`](https://togithub.com/leonsteinhaeuser/project-beta-automations/releases/tag/v2.0.1)

[Compare Source](https://togithub.com/leonsteinhaeuser/project-beta-automations/compare/v2.0.0...v2.0.1)

#### What's Changed

-   fix: positive actions state on error call by [@&#8203;leonsteinhaeuser](https://togithub.com/leonsteinhaeuser) in [leonsteinhaeuser/project-beta-automations#54

**Full Changelog**: leonsteinhaeuser/project-beta-automations@v2.0.0...v2.0.1

</details>

<details>
<summary>nosborn/github-action-markdown-cli</summary>

### [`v3.2.0`](https://togithub.com/nosborn/github-action-markdown-cli/releases/tag/v3.2.0)

[Compare Source](https://togithub.com/nosborn/github-action-markdown-cli/compare/v3.1.0...v3.2.0)

-   Exposes `--dot` option
-   Bumps `markdownlint-cli` to `0.32.2`

### [`v3.1.0`](https://togithub.com/nosborn/github-action-markdown-cli/releases/tag/v3.1.0)

[Compare Source](https://togithub.com/nosborn/github-action-markdown-cli/compare/v3.0.1...v3.1.0)

#### What's Changed

-   Bump markdownlint-cli dependency version by [@&#8203;daconstenla](https://togithub.com/daconstenla) in [nosborn/github-action-markdown-cli#38

#### New Contributors

-   [@&#8203;daconstenla](https://togithub.com/daconstenla) made their first contribution in [nosborn/github-action-markdown-cli#38

**Full Changelog**: nosborn/github-action-markdown-cli@v3.0.1...v3.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODUuMyIsInVwZGF0ZWRJblZlciI6IjMyLjE4NS4zIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix size/XS Denotes a PR that changes 0-99 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

[ BUG ]: Action fails (due to token permissions), but shows as successful
1 participant