Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate dims of tesseroids + check for 0 volume #27

Merged
merged 2 commits into from May 23, 2017
Merged

Conversation

@leouieda
Copy link
Owner

@leouieda leouieda commented May 23, 2017

Check if dimensions of the tesseroid were passed in the correct order
(fixes #23). This results in an error and the program terminates.

Also check if a tesseroid has zero volume (e.g., W == E, S == N, top ==
bottom). These tesseroids are now ignored (they don't contribute to
the gravitational effects). If not, they can cause infinite loops and
stack overflows during adaptive discretization.

leouieda added 2 commits May 23, 2017
Check if dimensions of the tesseroid were passed in the correct order
(fixes # 23). This results in an error and the program terminates.

Also check if a tesseroid has zero volume (e.g., W == E, S == N, top ==
bottom). These tesseroids are now ignored (they don't contribute to
the gravitational effects). If not, they can cause infinite loops and
stack overflows during adaptive discretization.
@leouieda leouieda merged commit 4f001ba into master May 23, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@leouieda leouieda deleted the tess-dimensions branch May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant