Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatHOBO - Additional DO parameters #117

Closed
leppott opened this issue Feb 22, 2021 · 6 comments
Closed

formatHOBO - Additional DO parameters #117

leppott opened this issue Feb 22, 2021 · 6 comments

Comments

@leppott
Copy link
Owner

leppott commented Feb 22, 2021

Is your feature request related to a problem? Please describe.
Getting the reformat HOBO function in the Shiny app to work for the DO parameters. The Northeast lake folks have worked up their DO data in HOBOware and we’re hoping not to have to manually reformat their DO data.

Describe the solution you'd like
Three possible outputs for DO.

Describe alternatives you've considered
NA

Additional context
There are three possible parameters in the HOBO csv outputs (see attached example) -
• DO conc, mg/L
• DO Adj Conc, mg/L
• DO Percent Sat, %

‘DO conc’ is the base output (similar in concept to Sensor Depth (no reference water level measurement); here, DO conc is when people didn’t enter field calibration measurements when they processed their DO data in HOBOware). At a minimum, everyone will have DO conc in their output file.

DO conc, mg/L (LGR S/N: 20313269) WaterTemp, °C (LGR S/N: 20313269) DO Adj Conc, mg/L (LGR S/N: 20313269) DO Percent Sat, % (LGR S/N: 20313269)
@leppott leppott pinned this issue Feb 22, 2021
@leppott
Copy link
Owner Author

leppott commented Feb 23, 2021

Multiple edits:

  • formatHobo
  • Config (and associated versions in Shiny)
  • Report_Config.RMD (and Shiny version)

leppott added a commit that referenced this issue Feb 23, 2021
* refactor: Shiny server, zip files add -j to strip folder names, Issue #109
* refactor: Add additional DO parameters to config, Issue #117
* refactor: Update other versions of config, Issue #117
* docs: Update README install directions
* docs: README, trim lines to 80 characters
* docs: Move planned updates from NEWS to README
* refactor: Update Report_Config.rmd for new DO parameters, Issue #117
* refactor: Update Report_Config.rmd so sensor depth and water level are next
to each other
* refactor: Copy updated Report_Config.rmd to Shiny app, Issue #117
* refactor: Add additional DO parameters (n=3) to reformatHobo function
, Issue #117
@leppott
Copy link
Owner Author

leppott commented Feb 23, 2021

Date failing in example file.

leppott added a commit that referenced this issue Feb 23, 2021
* refactor: Fix date in example reformatHobo for DO file, Issue #117
* refactor: Update reformatHobo date time conversion to account for no seconds
and 2 vs 4 digit years, Issue #117
@leppott
Copy link
Owner Author

leppott commented Feb 23, 2021

Date format fixed to handle 2 and 4 digit years.

@leppott
Copy link
Owner Author

leppott commented Feb 23, 2021

Shiny app failing since no input for Hobo format. Need to add an input box.

leppott added a commit that referenced this issue Feb 24, 2021
* feature: Shiny formatHobo add inputselect for date format, Issue #117
* refactor: Shiny server.R remove full.names from zip routine preventing
proper construction of download zip file, Issue #109
@leppott leppott closed this as completed Feb 24, 2021
@leppott leppott reopened this Apr 29, 2022
@leppott
Copy link
Owner Author

leppott commented Apr 29, 2022

Duplicate DO columns giving errors.

#135

HoboWare Reformat fails with more than one DO field.

leppott added a commit that referenced this issue May 17, 2022
* fix: Update Report_QC.rmd table statements with useNA = ifany, Issue #117
* fix: Add new parameters to QC routine
    + DO adj, Issue #117
    + DO pct sat, Issue #117
    + Salinity, Issue #138
@leppott
Copy link
Owner Author

leppott commented May 17, 2022

No longer get errors with multiple DO fields.

@leppott leppott closed this as completed May 17, 2022
@leppott leppott unpinned this issue May 17, 2022
leppott added a commit that referenced this issue May 24, 2022
-   refactor: Update Report_QC.rmd used in Shiny app, Issue #117
-   feature: Prototype site data summary report, Issue #142
-   feature: Add google analytics to Shiny app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant