Fix netlisting for graphical components. #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lepton-netlist function `get-all-connections' doesn't any more ignore the fact that components connected to nets are graphical, which led to outputting of wrong netlists previously.
vzh
added a commit
to vzh/lepton-eda
that referenced
this pull request
Sep 9, 2018
The lepton issue lepton-eda#251 revealed that there was no test in the lepton-netlist test suite for filtering components having the "graphical=" attribute attached. This patch adds the test based on the schematic by dmn provided in the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lepton-netlist function
get-all-connectionsdoesn't any moreignore the fact that components connected to nets are graphical,
which led to outputting of wrong netlists previously.
Closes #250