Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path object improvements #318

Merged
merged 2 commits into from Jan 28, 2019
Merged

Path object improvements #318

merged 2 commits into from Jan 28, 2019

Conversation

@vzh
Copy link
Member

@vzh vzh commented Jan 13, 2019

Feature request by Karl Hammar:

Possible not ASAP, but, for paths (^H), to be able to have
round join styles instead of default miter style. See e.g.
http://www.delorie.com/archives/browse.cgi?p=geda-user/2018/07/12/13:25:11

And in the same vein, for filled paths with line width = 0, to really
have zero width, not some default width which will enlargen the
triangle (mostly arrow heads, but filled polygons in general).

I decided to not modify the schematic/symbol file format and do
the latter change in the simple way. Now, when line width of a
path is set to zero, the stroke is not rendered, thus allowing
drawing of filled figures without increasing their size by a half
of the line width, so the object sizes strongly correspond to what
the user wanted.

Attached is a
test symbol
by Karl Hammar.

vzh added 2 commits Jan 13, 2019
Instead, a line with 1 screen pixel width is drawn in GUI, and no
line is drawn by "lepton-cli export" command.
@vzh vzh force-pushed the vzh:path-object-improvements branch from 7ce7282 to bd28f2e Jan 14, 2019
@graahnul-grom
Copy link
Member

@graahnul-grom graahnul-grom commented Jan 25, 2019

An interesting (and very good) side effect: with this patch, different cap styles can be selected for path objects (with width != 0). It used to be always square.

@vzh
Copy link
Member Author

@vzh vzh commented Jan 28, 2019

It's not a side effect, but the first one of the requested features. OK, since it works for you, and there is no feedback yet from the original reporter, I'll merge the branch.

@vzh vzh merged commit c2d5845 into lepton-eda:master Jan 28, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vzh vzh added this to the 1.9.8 milestone Jan 28, 2019
@vzh vzh deleted the vzh:path-object-improvements branch Jan 28, 2019
vzh added a commit to vzh/lepton-eda that referenced this pull request Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants