Path object improvements #318
Merged
Conversation
Instead, a line with 1 screen pixel width is drawn in GUI, and no line is drawn by "lepton-cli export" command.
|
An interesting (and very good) side effect: with this patch, different |
|
It's not a side effect, but the first one of the requested features. OK, since it works for you, and there is no feedback yet from the original reporter, I'll merge the branch. |
vzh
added a commit
to vzh/lepton-eda
that referenced
this pull request
Aug 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Feature request by Karl Hammar:
I decided to not modify the schematic/symbol file format and do
the latter change in the simple way. Now, when line width of a
path is set to zero, the stroke is not rendered, thus allowing
drawing of filled figures without increasing their size by a half
of the line width, so the object sizes strongly correspond to what
the user wanted.
Attached is a
test symbol
by Karl Hammar.