Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guile 2.2 support #326

Merged
merged 2 commits into from Feb 1, 2019
Merged

Guile 2.2 support #326

merged 2 commits into from Feb 1, 2019

Conversation

@vzh
Copy link
Member

@vzh vzh commented Jan 28, 2019

This patch-set adds support for build with guile-2.2.

@vzh vzh force-pushed the vzh:guile-2.2-support branch from 9fbba5b to 22be959 Jan 28, 2019
vzh added 2 commits May 27, 2017
This partially reverts commit
bc61db7 with new versions used,
which allows compilation with guile-2.2.
When compiled with guile-2.2, make-action() always returned the
same thunk (action()) which made define-action not working since
it redefined make-action() each time it was called by setting new
properties for the same thunk, thus using the last defined
action() for each and every menu item. This didn't affect
guile-2.0 due to, probably, more loose code compilation. The issue
has been fixed by moving thunk creation to define-action syntax
which allows creation of new procedures each time it is evaluated.
@vzh vzh force-pushed the vzh:guile-2.2-support branch from 22be959 to 2f3d20e Jan 29, 2019
@vzh
Copy link
Member Author

@vzh vzh commented Feb 1, 2019

I'll apply these patches since they work at least on three systems :-)

@vzh vzh merged commit 442e595 into lepton-eda:master Feb 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vzh vzh added this to the 1.9.8 milestone Feb 1, 2019
@vzh vzh deleted the vzh:guile-2.2-support branch Feb 5, 2019
vzh added a commit to vzh/lepton-eda that referenced this pull request Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant