Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling in the lepton-schematic log window #485

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@graahnul-grom
Copy link
Member

@graahnul-grom graahnul-grom commented Oct 24, 2019

Make the log window scroll to the bottom whenever
a message is written to the log.

Log window's inability to automatically scroll
was reported in #238 and then fixed in #239
(git: fc72ce3).
However, as it was discovered recently (#480),
current implementation of that fix may lead to
crash on some systems (Debian, in particular)
when File->Print is invoked. The crash itself
was fixed in git ad4ada5, and this commit fixes
scrolling again.

Make the log window scroll to the bottom whenever
a message is written to the log.
Log window's inability to automatically scroll
was reported in #238 and then fixed in #239
(git: fc72ce3).
However, as it was discovered recently (#480),
current implementation of that fix may lead to
crash on some systems (Debian, in particular)
when File->Print is invoked. The crash itself
was fixed in git ad4ada5, and this commit fixes
scrolling again.
@vzh vzh merged commit a4b99ac into lepton-eda:master Oct 24, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vzh vzh added this to the 1.9.10 milestone Oct 24, 2019
@vzh
Copy link
Member

@vzh vzh commented Oct 24, 2019

Thank you!

@graahnul-grom graahnul-grom deleted the graahnul-grom:tb_206_log_scroll_again branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants