Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSRV Bump to 1.80.0, drop crate lazy_static and use std::sync::LazyLock. #2767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MSRV Bump to 1.80.0, drop crate lazy_static and use std::sync::LazyLock. #2767

wants to merge 1 commit into from

Conversation

martinfrances107
Copy link
Contributor

@martinfrances107 martinfrances107 commented Aug 4, 2024 •
edited

@martinfrances107
Copy link
Contributor Author

Sorry for the commit spree ... finally found the path out of the woods.

@sabify
Copy link
Contributor

sabify commented Aug 5, 2024

Examples and benchmarks are excluded from the workspace and bumping the MSRV in the workspace is nonsense here. You may add MSRV to each example's Cargo.toml, not the workspace.

@martinfrances107
Copy link
Contributor Author

You may add MSRV to each example's Cargo.toml, not the workspace.

Ok ... change is comming

@martinfrances107 martinfrances107 mentioned this pull request Aug 5, 2024
Open
rakshith-ravi
rakshith-ravi approved these changes Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@rakshith-ravi rakshith-ravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been sitting on this for a week. I think it shouldn't be the biggest problem to upgrade MSRV. Looks good to me.

@martinfrances107 you might want to hold off on the merge conflict resolution until we get a consensus about upgrading MSRV, lest I'm worried we end up wasting your time.

@martinfrances107
Copy link
Contributor Author

you might want to hold off on the merge conflict resolution until we get a consensus about upgrading MSRV

Understood - It only took me a short time to reconstruct the PR .. force push is comming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakshith-ravi rakshith-ravi rakshith-ravi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martinfrances107 @sabify @rakshith-ravi