New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compilation of webfonts using webfonts-loader and webfonts-generator #305

Open
padcom opened this Issue Dec 14, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@padcom

padcom commented Dec 14, 2017

Do you want to request a feature or report a bug?

This is a feature request

What is the current behavior?

Webfonts need to be manually compiled outside of the default process.

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?

All modules ending with .font.js should be processed by webfonts-loader (https://www.npmjs.com/package/webfonts-loader), the generated font should be available as an external resource loaded by css generated by the webfonts-loader.

If this is a feature request, what is the motivation or use case for changing the behavior?

In most of modern projects people use webfonts as means to include custom icons. This is a good practice as it allows to minimize the number of files that need to be downloaded thus speeding things up when loading the page.

Please mention other relevant information such as the browser version, Node.js version, Poi version and Operating System.

@padcom

This comment has been minimized.

Show comment
Hide comment
@padcom

padcom Dec 14, 2017

Alternatively if it is at all possible to do it using poi.config.js then I'm happy to not make it part of default POI configuration. Although if it will be too long then at least a preset to enable this feature would be nice.

padcom commented Dec 14, 2017

Alternatively if it is at all possible to do it using poi.config.js then I'm happy to not make it part of default POI configuration. Although if it will be too long then at least a preset to enable this feature would be nice.

@egoist

This comment has been minimized.

Show comment
Hide comment
@egoist

egoist Dec 15, 2017

Collaborator

Although if it will be too long then at least a preset to enable this feature would be nice.

Yeah you can make a preset out of it. I can help if you met some problems.

btw can you show me some example projects that are using this approach (i.e. load svg as icon fonts)?

Collaborator

egoist commented Dec 15, 2017

Although if it will be too long then at least a preset to enable this feature would be nice.

Yeah you can make a preset out of it. I can help if you met some problems.

btw can you show me some example projects that are using this approach (i.e. load svg as icon fonts)?

@padcom

This comment has been minimized.

Show comment
Hide comment
@padcom

padcom Dec 18, 2017

What do you mean?

padcom commented Dec 18, 2017

What do you mean?

@egoist

This comment has been minimized.

Show comment
Hide comment
@egoist

egoist Dec 20, 2017

Collaborator

I mean a preset would be nice, PR is welcome for that.

Collaborator

egoist commented Dec 20, 2017

I mean a preset would be nice, PR is welcome for that.

@padcom

This comment has been minimized.

Show comment
Hide comment
@padcom

padcom Dec 20, 2017

padcom commented Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment