New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`from authlib.specs.oidc import AuthorizationCodeMixin` in OAuth sqla.py #57

Closed
ThiefMaster opened this Issue May 25, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@ThiefMaster

ThiefMaster commented May 25, 2018

OAuth isn't openid connect, so shouldn't OAuth2AuthorizationCodeMixin inherit from the AuthorizationCodeMixin from rfc6479 instead of oidc?

lepture added a commit that referenced this issue May 25, 2018

lepture added a commit that referenced this issue May 25, 2018

@lepture

This comment has been minimized.

Owner

lepture commented May 25, 2018

Yes, you are right. Because OpenID Connect has a superset of OAuth 2 AuthorizationCode, I was lazy to create separated ones for each of them.

@lepture lepture closed this May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment