New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`TypeError` fix when using no `refresh_token_params`. #14

Merged
merged 1 commit into from Jan 11, 2018

Conversation

Projects
None yet
3 participants
@nfvs
Contributor

nfvs commented Jan 10, 2018

Fixes #13

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

(If no, please delete the above question and this text message.)


  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@nfvs nfvs force-pushed the nfvs:refresh_token_params branch from 052d39c to 6c4cac2 Jan 10, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Jan 10, 2018

Codecov Report

Merging #14 into master will increase coverage by 0.24%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #14      +/-   ##
=========================================
+ Coverage   84.15%   84.4%   +0.24%     
=========================================
  Files          64      64              
  Lines        2108    2109       +1     
  Branches      325     326       +1     
=========================================
+ Hits         1774    1780       +6     
+ Misses        208     203       -5     
  Partials      126     126
Impacted Files Coverage Δ
authlib/client/oauth2.py 79.1% <50%> (-0.6%) ⬇️
authlib/common/urls.py 76.92% <0%> (+3.84%) ⬆️
authlib/common/encoding.py 66.66% <0%> (+12.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259c210...6c4cac2. Read the comment docs.

@nfvs nfvs changed the title from `TypeError` fix when using empty `refresh_token_params`. to `TypeError` fix when using no `refresh_token_params`. Jan 10, 2018

@lepture lepture changed the base branch from master to work-0.4 Jan 11, 2018

@lepture lepture changed the base branch from work-0.4 to master Jan 11, 2018

@lepture lepture merged commit e01aafd into lepture:master Jan 11, 2018

2 of 3 checks passed

codecov/patch 50% of diff hit (target 84.15%)
Details
codecov/project 84.4% (+0.24%) compared to 259c210
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lepture

This comment has been minimized.

Owner

lepture commented Jan 11, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment