Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from the httpx public API. #232

Merged
merged 2 commits into from May 15, 2020
Merged

Conversation

tomchristie
Copy link
Contributor

@tomchristie tomchristie commented May 15, 2020

A couple of changes here to start to make sure that authlib only imports from the httpx public API...

  • Import Request/Response from the top-level API.
  • Switch to using httpx.AsyncClient(app=...) instead of relying on the undocumented dispatch API.

I still need to look at the usage of the ContentStreams API and figure out if https://github.com/encode/httpx/pull/932/files is the right approach, or if there's already sufficient public API here, and the auth flow just need re-jigging.


  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

(If no, please delete the above question and this text message.)


  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@lepture lepture merged commit c015ec7 into lepture:master May 15, 2020
5 checks passed
@tomchristie tomchristie deleted the httpx-public-api branch May 15, 2020
@lepture lepture mentioned this pull request May 18, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants