Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usage of private httpx ContentStreams #233

Conversation

tomchristie
Copy link
Contributor

@tomchristie tomchristie commented May 17, 2020

Rejig the auth flow slightly, so as to not rely on httpx's private ContentStreams.

After this fix I believe authlib should be compatible with httpx 0.12, the upcoming 0.13, and the planned 1.x series.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

(If no, please delete the above question and this text message.)


  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@lepture lepture merged commit e59c09d into lepture:master May 18, 2020
5 checks passed
@lepture
Copy link
Owner

@lepture lepture commented May 18, 2020

Thanks

@lepture lepture mentioned this pull request May 18, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants