Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#268 #269 Improve HTTPX Support #270

Merged
merged 8 commits into from Sep 17, 2020
Merged

Conversation

zoidbb
Copy link
Contributor

@zoidbb zoidbb commented Sep 10, 2020

Fixes #268
Fixes #269

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes

  • No

  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@zoidbb zoidbb changed the title #268 #269Improve HTTPX Support #268 #269 Improve HTTPX Support Sep 10, 2020
@lepture
Copy link
Owner

lepture commented Sep 10, 2020

@berzoidberg I'm not ready to support sync mode of httpx. currently httpx is not stable, it has many breaking changes. For example, I have locked httpx version to httpx==0.14.1, because 0.14.2 will break our code. I'd like to fix test cases for httpx==0.14.2 at first.

@zoidbb
Copy link
Contributor Author

zoidbb commented Sep 10, 2020

I can get that done. 0.14.3 is the latest, should I aim to get tests working with that version instead?

@zoidbb
Copy link
Contributor Author

zoidbb commented Sep 10, 2020

@lepture Successfully updated to work w/HTTPX 0.14.3 -- the newest available.

add support for httpx sync APIs; fix bug in httpx oauth1 support where content-length header si not specific

update to httpx 0.14.3

Remove deprecated and purely cosmetical argument providing_args in Django integrations

add test and fix for unintentional parallel token refreshes

update to work with latest master
@lepture
Copy link
Owner

lepture commented Sep 10, 2020

Actually, we had HTTPX sync API before, in version 0.13. But later after we released 0.13, HTTPX removed sync API for a while.

@zoidbb
Copy link
Contributor Author

zoidbb commented Sep 10, 2020

Aye, in HTTPX 0.13.0 they released the new sync client, sync and async both use the same codebase with some minor interface differences now. I'll gladly volunteer to continue maintaining HTTPX support as they make changes if we can get this merged up.

@zoidbb
Copy link
Contributor Author

zoidbb commented Sep 10, 2020

@lepture thanks for the review, i removed the unnecessary bits from all 3 client types (assertion, oauth1, oauth2)

@zoidbb zoidbb force-pushed the improve-httpx-support branch 3 times, most recently from ee66053 to 340168b Compare September 10, 2020 09:39
@lepture lepture merged commit 6a4778d into lepture:master Sep 17, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for HTTPX Synchronous API HTTPX OAuth1 implementation does not set Content-Length header
2 participants