Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request_token_params and **kwargs don't append to url #91

Closed
BradleyMoore opened this issue Apr 1, 2014 · 2 comments

Comments

@BradleyMoore
Copy link

commented Apr 1, 2014

On line 454-458 in flask_oauthlib/client.py your code says:

if self.request_token_url:
    token = self.generate_request_token(callback)[0]
    url = '%s?oauth_token=%s' % (
        self.expand_url(self.authorize_url), url_quote(token)
    )

The problem is that neither request_token_params nor the authorize **kwargs value get attached to the end of the url. This creates a problem specifically for flickr which requires perms=read to access the user information.

@BradleyMoore BradleyMoore changed the title request_token_params request_token_params and **kwargs don't append to url Apr 1, 2014

lepture added a commit that referenced this issue Apr 2, 2014

@lepture

This comment has been minimized.

Copy link
Owner

commented Apr 2, 2014

How about this change: 0f96b5e

@BradleyMoore

This comment has been minimized.

Copy link
Author

commented Apr 2, 2014

It works! Thanks so much, Flickr was a no go until this change. I greatly appreciate it.

@lepture lepture closed this Apr 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.