Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Secret not being verified. Able to generate access token with wrong client secret. #92

Closed
namanbansal opened this issue Apr 2, 2014 · 5 comments

Comments

@namanbansal
Copy link

commented Apr 2, 2014

I am building up on the "Create OAuth Server Example" and the code is able to generate the oauth token even when I send the wrong client secret. Is the client secret not being verified by default while generating the access token by OAuth2Provider?

@lepture

This comment has been minimized.

Copy link
Owner

commented Apr 3, 2014

@namanbansal code response type doesn't need a secret to get access token.

@lepture lepture closed this Apr 3, 2014

@namanbansal

This comment has been minimized.

Copy link
Author

commented Apr 3, 2014

Should I change the response type to 'token'? Will I have to make any more changes to get the client secret being verified?

@lepture

This comment has been minimized.

Copy link
Owner

commented Apr 3, 2014

@namanbansal I am sorry. It's not access token, it's grant code.

@namanbansal

This comment has been minimized.

Copy link
Author

commented Apr 3, 2014

@lepture By default the example code that you have given for creating OAuth Server doesn't check for client secret. How do I verify the client secret before sending the access token?

@lepture lepture reopened this Apr 3, 2014

lepture added a commit that referenced this issue Apr 3, 2014

@lepture

This comment has been minimized.

Copy link
Owner

commented Apr 3, 2014

@namanbansal WOW. This is a security bug.

@lepture lepture closed this Apr 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.