Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you a human integration from http://areyouahuman.com #158

Closed
wants to merge 12 commits into from
Closed

Are you a human integration from http://areyouahuman.com #158

wants to merge 12 commits into from

Conversation

sboily
Copy link

@sboily sboily commented Oct 8, 2014

This is #109 rebased.

import urllib2 as http
except ImportError:
# Python 3
from urllib import request as http
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those could be placed into flask_wtf/_compat.py.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In recaptcha/validators.py it's the same, i've just copy to be identical.

@tonyseek
Copy link
Contributor

tonyseek commented Oct 9, 2014

You may need to use flake8 to lint your sources according to the PEP8.

@lipis
Copy link
Contributor

lipis commented Oct 9, 2014

Eventually you might want to squash all the commits if this is about to get merged..

@lipis
Copy link
Contributor

lipis commented Oct 9, 2014

and for what is worth.. I would rather keep that separately.. one captcha is more than enough for the library!

@sboily
Copy link
Author

sboily commented Oct 9, 2014

maybe, but this captcha better for the end user.

@lipis
Copy link
Contributor

lipis commented Oct 9, 2014

Better for end user? Start dragging eyes to the face, cars to clean the road, flying chickens to fill the sandwich?! No thank you.. I would rather type a word or two..

P.S. Didn't test it on the phone... and I don't really want to actually try to catch flying eyes and drag them on the face...

@davidism
Copy link
Member

@lepture I think we should avoid adding more of these types of fields. This would be great as a separate package, wtforms-areyouahuman. Do you agree?

@lepture
Copy link
Contributor

lepture commented Jul 1, 2016

@davidism Aye.

@lepture lepture closed this Jul 1, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants