Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "===" suffix of base32 encoded secret #1

Merged
merged 1 commit into from Jul 4, 2013
Merged

Conversation

@sublee
Copy link
Contributor

@sublee sublee commented Jul 4, 2013

Hi Hsiaoming,

I patched OtpAuth.to_google to remove "===" suffix of base32 encoded secret. Because my Google Authenticator failed to read a QRCode when "===" exists.

Please confirm my pull request and update the version.

@lepture
Copy link
Owner

@lepture lepture commented Jul 4, 2013

@sublee Any documentation on Google striped === ?

@lepture
Copy link
Owner

@lepture lepture commented Jul 4, 2013

http://tools.ietf.org/html/rfc3548


                   Table 1: The Base 64 Alphabet

      Value Encoding  Value Encoding  Value Encoding  Value Encoding
          0 A            17 R            34 i            51 z
          1 B            18 S            35 j            52 0
          2 C            19 T            36 k            53 1
          3 D            20 U            37 l            54 2
          4 E            21 V            38 m            55 3
          5 F            22 W            39 n            56 4
          6 G            23 X            40 o            57 5
          7 H            24 Y            41 p            58 6
          8 I            25 Z            42 q            59 7
          9 J            26 a            43 r            60 8
         10 K            27 b            44 s            61 9
         11 L            28 c            45 t            62 +
         12 M            29 d            46 u            63 /
         13 N            30 e            47 v
         14 O            31 f            48 w         (pad) =
         15 P            32 g            49 x
         16 Q            33 h            50 y

I will have a try on Google

@sublee
Copy link
Contributor Author

@sublee sublee commented Jul 4, 2013

No I couldn't find. I'll wait you to test with === in your Google Authenticator.

@lepture
Copy link
Owner

@lepture lepture commented Jul 4, 2013

@sublee Yes, you are right, we need to remove the pad string for Google.

@sublee
Copy link
Contributor Author

@sublee sublee commented Jul 4, 2013

Thanks to test it. Would you accept this pull request?

lepture added a commit that referenced this pull request Jul 4, 2013
remove "===" suffix of base32 encoded secret
@lepture lepture merged commit a69bf66 into lepture:master Jul 4, 2013
1 check failed
1 check failed
default The Travis CI build failed
Details
lepture added a commit that referenced this pull request Jul 4, 2013
@lepture
Copy link
Owner

@lepture lepture commented Jul 4, 2013

@sublee 0.1.1 is released.

@sublee
Copy link
Contributor Author

@sublee sublee commented Jul 4, 2013

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.