Server.serve ignores root argument #76

Closed
ngzhian opened this Issue Nov 3, 2014 · 6 comments

Projects

None yet

2 participants

@ngzhian
ngzhian commented Nov 3, 2014

e.g.

server.serve(root=config['static_dir'])
# app will be served out of CWD regardless of the value of root

Looks like it has to do with Server.root being initialized to None, and when serve is called, the parameter root is ignored.
Not sure if this is the intended behavior. Thanks!

@lepture
Owner
lepture commented Nov 3, 2014

@ngzhian It's definitely a bug. Thanks for your repot.

@lepture lepture added a commit that referenced this issue Nov 3, 2014
@lepture Fix root parameter. 6358670
@ngzhian
ngzhian commented Nov 3, 2014

@lepture no problem, thanks for the quick response! Will this be scheduled for a pypi push soon?

@lepture
Owner
lepture commented Nov 3, 2014

@ngzhian This bug was introduced in version 2.3 when I refactored the Server code. If I won't find any bug in the near two days, I will release a new version 2.3.2.

@ngzhian
ngzhian commented Nov 3, 2014

@lepture got it, thanks for this library, really simple and easy to use!

@lepture lepture closed this Nov 3, 2014
@lepture
Owner
lepture commented Nov 6, 2014

@ngzhian New version was released.

@ngzhian
ngzhian commented Nov 8, 2014

@lepture cool thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment