Handle failures to set certain memcache behaviors #86

Merged
merged 1 commit into from Mar 26, 2012

Conversation

Projects
None yet
2 participants
Contributor

Roguelazer commented Mar 24, 2012

It's possible for some behavior sets to fail on older versions of libmemcached; we should detect this and respond appropriately.

lericson merged commit a816e22 into lericson:master Mar 26, 2012

Owner

lericson commented Mar 26, 2012

Thanks!

Owner

lericson commented Mar 28, 2012

Actually, when does this fail?

Owner

lericson commented Mar 28, 2012

Also, did you even test this? The printf arguments are of the wrong types. :-/

Contributor

Roguelazer commented Mar 29, 2012

I actually wrote it against a last-year version of pylibmc and libmemcached; it may be that the types no longer quite line up...

My recollection is that these fail if the pool against which they're being called is empty, and attempting to use the Client object after that failure had been ignored was having strange effects.

Owner

lericson commented Mar 29, 2012

Aha I see, I doubt the behavior constants changed type during that time though; it seems to be a copy paste error. I have a new version locally, will push soon

Sent from phone

-------- Original Message --------
Subject: Re: [pylibmc] Handle failures to set certain memcache behaviors (#86)
From: James Brown reply@reply.github.com
To: Ludvig Ericson ludvig@lericson.se
CC:

I actually wrote it against a last-year version of pylibmc and libmemcached; it may be that the types no longer quite line up...

My recollection is that these fail if the pool against which they're being called is empty, and attempting to use the Client object after that failure had been ignored was having strange effects.


Reply to this email directly or view it on GitHub:
#86 (comment)

@lericson lericson added a commit that referenced this pull request Mar 31, 2012

@lericson lericson Revert "Merge pull request #86 from Roguelazer/handle_behavior_set_fa…
…ilures"

This reverts commit a816e22, reversing
changes made to 01c47fa.

Refs #86
0260c3e

@lericson lericson added a commit that referenced this pull request Mar 31, 2012

@lericson lericson Test for errors in once-off behaviors
Refs #86
72bde6a

@lericson lericson added a commit that referenced this pull request Mar 31, 2012

@lericson lericson accredit @Rougelazer for 72bde6a
refs #86
0aacf86

@nhooey nhooey pushed a commit to vine/pylibmc that referenced this pull request Aug 16, 2013

@lericson lericson Test for errors in once-off behaviors
Refs #86
0842622

@nhooey nhooey pushed a commit to vine/pylibmc that referenced this pull request Aug 16, 2013

@lericson lericson accredit @Rougelazer for 72bde6a
refs #86
4c138fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment