From 735fbe66069ef0b9389faf850ae7900ddd076f4d Mon Sep 17 00:00:00 2001 From: ghiscoding Date: Mon, 6 Jun 2022 17:29:11 -0400 Subject: [PATCH] fix(version): improve default git publish message, closes #185 --- .../__tests__/__snapshots__/version-command.spec.ts.snap | 2 +- .../__snapshots__/version-conventional-commits.spec.ts.snap | 6 +++--- .../version/src/__tests__/version-bump-prerelease.spec.ts | 6 +++--- packages/version/src/version-command.ts | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/version/src/__tests__/__snapshots__/version-command.spec.ts.snap b/packages/version/src/__tests__/__snapshots__/version-command.spec.ts.snap index 34cfda7c..3530f752 100644 --- a/packages/version/src/__tests__/__snapshots__/version-command.spec.ts.snap +++ b/packages/version/src/__tests__/__snapshots__/version-command.spec.ts.snap @@ -188,7 +188,7 @@ index SHA..SHA 100644 `; exports[`VersionCommand independent mode versions changed packages: commit 1`] = ` -"Publish +"chore: Publish new release - package-1@1.0.1 - package-2@2.1.0 diff --git a/packages/version/src/__tests__/__snapshots__/version-conventional-commits.spec.ts.snap b/packages/version/src/__tests__/__snapshots__/version-conventional-commits.spec.ts.snap index 144e7b0e..b28355ad 100644 --- a/packages/version/src/__tests__/__snapshots__/version-conventional-commits.spec.ts.snap +++ b/packages/version/src/__tests__/__snapshots__/version-conventional-commits.spec.ts.snap @@ -39,7 +39,7 @@ packages/package-5/package.json" `; exports[`--conventional-commits independent should graduate prerelease version bumps and generate CHANGELOG 1`] = ` -"Publish +"chore: Publish new release - package-1@1.0.1 - package-2@2.1.0 @@ -62,7 +62,7 @@ packages/package-5/package.json" `; exports[`--conventional-commits independent should guess prerelease version bumps and generate CHANGELOG 1`] = ` -"Publish +"chore: Publish new release - package-1@1.0.1-alpha.0 - package-2@2.1.0-alpha.0 @@ -85,7 +85,7 @@ packages/package-5/package.json" `; exports[`--conventional-commits independent should use conventional-commits utility to guess version bump and generate CHANGELOG 1`] = ` -"Publish +"chore: Publish new release - package-1@1.0.1 - package-2@2.1.0 diff --git a/packages/version/src/__tests__/version-bump-prerelease.spec.ts b/packages/version/src/__tests__/version-bump-prerelease.spec.ts index 711219b7..02925b7f 100644 --- a/packages/version/src/__tests__/version-bump-prerelease.spec.ts +++ b/packages/version/src/__tests__/version-bump-prerelease.spec.ts @@ -180,7 +180,7 @@ test("independent version prerelease does not bump on every unrelated change", a const first = await getCommitMessage(cwd); expect(first).toMatchInlineSnapshot(` -Publish +chore: Publish new release - pkg-a@1.0.1 - pkg-b@1.0.0-bumps.2 @@ -195,7 +195,7 @@ Publish const second = await getCommitMessage(cwd); expect(second).toMatchInlineSnapshot(` - Publish + chore: Publish new release - pkg-a@1.0.2 `); @@ -242,7 +242,7 @@ test("independent version prerelease respects --no-private", async () => { const changedFiles = await showCommit(cwd, "--name-only"); expect(changedFiles).toMatchInlineSnapshot(` - Publish + chore: Publish new release - pkg-1@1.0.1-alpha.0 diff --git a/packages/version/src/version-command.ts b/packages/version/src/version-command.ts index c22a5b6b..5829f18d 100644 --- a/packages/version/src/version-command.ts +++ b/packages/version/src/version-command.ts @@ -717,7 +717,7 @@ export class VersionCommand extends Command { async gitCommitAndTagVersionForUpdates() { const tags = this.packagesToVersion.map((pkg) => `${pkg.name}@${this.updatesVersions?.get(pkg.name)}`); - const subject = this.options.message || 'Publish'; + const subject = this.options.message || 'chore: Publish new release'; const message = tags.reduce((msg, tag) => `${msg}${os.EOL} - ${tag}`, `${subject}${os.EOL}`); await gitCommit(message, this.gitOpts, this.execOpts, this.options.gitDryRun);