Skip to content

Commit

Permalink
build: Set LC_ALL env var in setup file, not shell
Browse files Browse the repository at this point in the history
  • Loading branch information
evocateur committed Oct 12, 2018
1 parent 433162b commit 349d43a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 13 deletions.
3 changes: 3 additions & 0 deletions helpers/set-npm-userconfig/index.js
Expand Up @@ -3,3 +3,6 @@
// Overwrite npm userconfig to avoid test pollution
// https://docs.npmjs.com/misc/config#npmrc-files
process.env.npm_config_userconfig = require("path").resolve(__dirname, "test-user.ini");

// use consistent locale for all tests
process.env.LC_ALL = "en_US.UTF-8";
10 changes: 0 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
Expand Up @@ -6,10 +6,10 @@
"scripts": {
"ci": "npm test -- --ci --maxWorkers=2 && npm run integration -- --ci",
"fix": "npm run lint -- --fix",
"integration": "cross-env LC_ALL=en_US.UTF-8 jest --config jest.integration.js --maxWorkers=2",
"integration": "jest --config jest.integration.js --maxWorkers=2",
"lint": "eslint . --ignore-path .gitignore --cache",
"pretest": "npm run lint",
"test": "cross-env LC_ALL=en_US.UTF-8 jest"
"test": "jest"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -53,7 +53,6 @@
"@lerna-test/silence-logging": "file:helpers/silence-logging",
"@lerna-test/update-lerna-config": "file:helpers/update-lerna-config",
"camelcase": "^4.1.0",
"cross-env": "^5.2.0",
"eslint": "^5.6.1",
"eslint-config-airbnb-base": "^13.1.0",
"eslint-config-prettier": "^3.1.0",
Expand Down

0 comments on commit 349d43a

Please sign in to comment.