New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump major version before releasing license change. #1628

Closed
phpnode opened this Issue Aug 29, 2018 · 9 comments

Comments

Projects
None yet
4 participants
@phpnode

phpnode commented Aug 29, 2018

A polite and hopefully unnecessary reminder that when the license change is released it should be a major version bump. I'm imagining the fall out that would occur if this were released as a patch version and it wouldn't be pretty.

Note: Arguments for / against the license change are happening in other issues, let's please keep them out of this one.

@jamiebuilds

This comment has been minimized.

Show comment
Hide comment
@jamiebuilds

jamiebuilds Aug 29, 2018

Contributor

maybe

Contributor

jamiebuilds commented Aug 29, 2018

maybe

@hallister

This comment has been minimized.

Show comment
Hide comment
@hallister

hallister Aug 29, 2018

You're going to introduce a major license change, refuse to change the license name and do it in a minor version bump? What the actual hell is your goal here?

hallister commented Aug 29, 2018

You're going to introduce a major license change, refuse to change the license name and do it in a minor version bump? What the actual hell is your goal here?

@jamiebuilds

This comment has been minimized.

Show comment
Hide comment
@jamiebuilds

jamiebuilds Aug 29, 2018

Contributor

To screw with companies that support ICE, was that not clear?

Contributor

jamiebuilds commented Aug 29, 2018

To screw with companies that support ICE, was that not clear?

@hallister

This comment has been minimized.

Show comment
Hide comment
@hallister

hallister Aug 29, 2018

By releasing a major license change as a minor version bump and using an incorrect license in the license field? You're screwing Lerna, not the companies listed. Ignoring you politicizing something that has no business being political (especially as a former Facebook employee... come on), literally every company listed is going to update their packages to pull from https://github.com/LernaOpenSource/LernaOpenSource and go back to work. Meanwhile you're getting massive community backlash that's only going to continue if you decide to be a child and inappropriately release this as a minor version bump or with the MIT license.

The best thing feasible for Lerna at this point is you leaving the project. But since that's not going to happen since you apparently enjoy your soap box, the second best thing is everyone moving to a fork of the project without a politician having any control.

The irony is I 100% agree with your politics, but this is not the place to express them.

hallister commented Aug 29, 2018

By releasing a major license change as a minor version bump and using an incorrect license in the license field? You're screwing Lerna, not the companies listed. Ignoring you politicizing something that has no business being political (especially as a former Facebook employee... come on), literally every company listed is going to update their packages to pull from https://github.com/LernaOpenSource/LernaOpenSource and go back to work. Meanwhile you're getting massive community backlash that's only going to continue if you decide to be a child and inappropriately release this as a minor version bump or with the MIT license.

The best thing feasible for Lerna at this point is you leaving the project. But since that's not going to happen since you apparently enjoy your soap box, the second best thing is everyone moving to a fork of the project without a politician having any control.

The irony is I 100% agree with your politics, but this is not the place to express them.

@phpnode

This comment has been minimized.

Show comment
Hide comment
@phpnode

phpnode Aug 29, 2018

@jamiebuilds i would personally appreciate some certainty around this, because if you're likely to release this under a patch version I now need to go through all my clients' repos to make sure they're using lock files, fixed versions or a fork. Not because my clients are Microsoft et al but because they have contractually approved lists of licenses that we can use and this license will not qualify.

To screw with companies that support ICE, was that not clear?

The intent is pretty clear, but the unfortunate side effect is that it also screws with many developers who use this tool. I know this wasn't your intention but it sucks if I have to spend my evening checking a bunch of old repos because you'll maybe release this as a patch.

phpnode commented Aug 29, 2018

@jamiebuilds i would personally appreciate some certainty around this, because if you're likely to release this under a patch version I now need to go through all my clients' repos to make sure they're using lock files, fixed versions or a fork. Not because my clients are Microsoft et al but because they have contractually approved lists of licenses that we can use and this license will not qualify.

To screw with companies that support ICE, was that not clear?

The intent is pretty clear, but the unfortunate side effect is that it also screws with many developers who use this tool. I know this wasn't your intention but it sucks if I have to spend my evening checking a bunch of old repos because you'll maybe release this as a patch.

@jamiebuilds

This comment has been minimized.

Show comment
Hide comment
@jamiebuilds

jamiebuilds Aug 29, 2018

Contributor

The best thing feasible for Lerna at this point is you leaving the project.

I left the Lerna project a long time ago, I've gone as far as to replace Lerna with a new tool called Bolt.

The irony is I 100% agree with your politics, but this is not the place to express them.

All technology is political, open source is especially political. It would not exist if not for political reasons. Open sourcing something is in itself a political act.

I know this wasn't your intention but it sucks if I have to spend my evening checking a bunch of old repos because you'll maybe release this as a patch.

We'll release it as major

Contributor

jamiebuilds commented Aug 29, 2018

The best thing feasible for Lerna at this point is you leaving the project.

I left the Lerna project a long time ago, I've gone as far as to replace Lerna with a new tool called Bolt.

The irony is I 100% agree with your politics, but this is not the place to express them.

All technology is political, open source is especially political. It would not exist if not for political reasons. Open sourcing something is in itself a political act.

I know this wasn't your intention but it sucks if I have to spend my evening checking a bunch of old repos because you'll maybe release this as a patch.

We'll release it as major

@jamiebuilds

This comment has been minimized.

Show comment
Hide comment
@jamiebuilds

jamiebuilds Aug 29, 2018

Contributor

especially as a former Facebook employee... come on

Once upon a time I thought I had to go work for those big corporations that I hate in order to do the kind of open source work I want to do. That turned out to be incredibly false. So I fucked off and told them to eat shit.

Contributor

jamiebuilds commented Aug 29, 2018

especially as a former Facebook employee... come on

Once upon a time I thought I had to go work for those big corporations that I hate in order to do the kind of open source work I want to do. That turned out to be incredibly false. So I fucked off and told them to eat shit.

@siziyman

This comment has been minimized.

Show comment
Hide comment
@siziyman

siziyman Aug 29, 2018

I left the Lerna project a long time ago,

As long as you're maintaining the repository and represent it in the face of other contributors and open source community members - no, you did not. Maintainer is a part of a project.

siziyman commented Aug 29, 2018

I left the Lerna project a long time ago,

As long as you're maintaining the repository and represent it in the face of other contributors and open source community members - no, you did not. Maintainer is a part of a project.

@jamiebuilds

This comment has been minimized.

Show comment
Hide comment
@jamiebuilds

jamiebuilds Aug 29, 2018

Contributor

Cool story

Contributor

jamiebuilds commented Aug 29, 2018

Cool story

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.