Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was the release v3.4.0 correct? #1690

Closed
MartinBlackburn opened this Issue Sep 19, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@MartinBlackburn
Copy link

MartinBlackburn commented Sep 19, 2018

Looking at the changelog for the release v3.4.0 I can see that the --no-verify-registry on lerna publish should have been removed.

Changelog: https://github.com/lerna/lerna/blob/v3.4.0/CHANGELOG.md
which points to the following commit: 65fc603

But looking at some of the changes in that commit, I can see they are not in the v3.40 tag or master branch:
https://github.com/lerna/lerna/blob/master/commands/publish/__tests__/publish-command.test.js#L256

@MartinBlackburn

This comment has been minimized.

Copy link
Author

MartinBlackburn commented Sep 26, 2018

Looks like it was correct and I was mistaken.

@lock

This comment has been minimized.

Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.