Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create): Use correct variable name in generated CLI output #2547

Merged
merged 2 commits into from May 24, 2020

Conversation

paleite
Copy link
Contributor

@paleite paleite commented Apr 17, 2020

Description

When creating a binary without the ES-module flag, the created CLI uses the wrong variable name when requiring yargs.
With the ES-module flag, however, it works.

This commit fixes the binary by using the same variable name when requiring, as the ES-module CLI does when importing.

Motivation and Context

It fixes the created CLIs

How Has This Been Tested?

Changed it, created a new binary and it worked.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yikes, thanks for your patience!

@evocateur evocateur changed the title Fix "ReferenceError: factory is not defined" fix(create): Use correct variable name in generated CLI output May 24, 2020
@evocateur evocateur merged commit a1fd622 into lerna:master May 24, 2020
@paleite paleite deleted the patch-1 branch June 6, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants