New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrinkwrap support #377

Closed
christianacca opened this Issue Oct 16, 2016 · 6 comments

Comments

Projects
None yet
5 participants
@christianacca

christianacca commented Oct 16, 2016

I shrinkwrap libraries. The problem is that lerna does not seem to support shrinkwrapped packages.

Is shrinkwrap support on the roadmap to be added?

Note: For best practice reasons, I shrinkwrap at development time only ie the published package on npm does NOT include the npm-shrinkwrap.json file.

Observations

When trying to use lerna with shrinkwrapped projects I've observed the following:

  • bootstrap command ignores the npm-shrinkwrap.json when installing versions of external dependencies
  • publish command does not update the npm-shrinkwrap.json file(s)
@jamiebuilds

This comment has been minimized.

Show comment
Hide comment
@jamiebuilds

jamiebuilds Nov 16, 2016

Contributor

We're going to switch to Yarn eventually, and we'll use yarn.lock's as part of that.

Contributor

jamiebuilds commented Nov 16, 2016

We're going to switch to Yarn eventually, and we'll use yarn.lock's as part of that.

@christianacca

This comment has been minimized.

Show comment
Hide comment
@christianacca

christianacca Nov 17, 2016

OK thanks for the heads up

On Wed, Nov 16, 2016 at 10:23 PM, James Kyle notifications@github.com
wrote:

We're going to switch to Yarn eventually, and we'll use yarn.lock's as
part of that.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#377 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA2HPga4VzTY4kwaS0XwamD9xX0l6zixks5q-4JRgaJpZM4KX6UV
.

christianacca commented Nov 17, 2016

OK thanks for the heads up

On Wed, Nov 16, 2016 at 10:23 PM, James Kyle notifications@github.com
wrote:

We're going to switch to Yarn eventually, and we'll use yarn.lock's as
part of that.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#377 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA2HPga4VzTY4kwaS0XwamD9xX0l6zixks5q-4JRgaJpZM4KX6UV
.

jan-molak added a commit to jan-molak/serenity-js that referenced this issue Mar 9, 2017

chore(lerna): lerna doesn't support shrinkwrap, I might need to switc…
…h to yarn...

Using npm shrinkwrap seems to be confusing lerna, which can no longer symlink local packages.
Removing the shrinkwrap works around the issue.

lerna/lerna#377
@chrisui

This comment has been minimized.

Show comment
Hide comment
@chrisui

chrisui Jun 14, 2017

Are there any plans to revisit this with the recent npm progressions (ie. v5 with package-lock.json).

I'm currently looking for the canonical answer to how "how do I lock my dependencies with a lerna managed monorepo?"

Also regarding "We're going to switch to Yarn eventually" what does the roadmap currently look like for lerna with yarn? Am I still going to be able to use lerna with npm in a few months?

chrisui commented Jun 14, 2017

Are there any plans to revisit this with the recent npm progressions (ie. v5 with package-lock.json).

I'm currently looking for the canonical answer to how "how do I lock my dependencies with a lerna managed monorepo?"

Also regarding "We're going to switch to Yarn eventually" what does the roadmap currently look like for lerna with yarn? Am I still going to be able to use lerna with npm in a few months?

@aaronmcadam

This comment has been minimized.

Show comment
Hide comment
@aaronmcadam

aaronmcadam Jun 15, 2017

@chrisui The original idea was that Yarn might take on Lerna's functionality, but I think that idea died when issues like caching differences were raised. I've always had problems using Yarn with Lerna, so yeah, it would be good to see where it fits into the roadmap.

aaronmcadam commented Jun 15, 2017

@chrisui The original idea was that Yarn might take on Lerna's functionality, but I think that idea died when issues like caching differences were raised. I've always had problems using Yarn with Lerna, so yeah, it would be good to see where it fits into the roadmap.

@evocateur

This comment has been minimized.

Show comment
Hide comment
@evocateur

evocateur Jun 15, 2017

Member

A roadmap is forthcoming

Member

evocateur commented Jun 15, 2017

A roadmap is forthcoming

@chrisui

This comment has been minimized.

Show comment
Hide comment
@chrisui

chrisui Jun 22, 2017

Awesome @evocateur, if I can be of any use let me know. We really want to use lerna but require a first-class dependency locking story so happy to invest!

chrisui commented Jun 22, 2017

Awesome @evocateur, if I can be of any use let me know. We really want to use lerna but require a first-class dependency locking story so happy to invest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment