feat: add verify flag to bypass --no-verify #1494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rufman
force-pushed
the
2.x
branch
2 times, most recently
from
d14f738
to
2003929
Compare
hutson
reviewed
Jul 18, 2018
| @@ -526,6 +526,14 @@ and you are not on the branch `master` lerna will prevent you from publishing. T | |||
| $ lerna publish --allow-branch my-new-feature | |||
| ``` | |||
|
|
|||
| #### --verify | |||
There was a problem hiding this comment.
I would suggest going with a name like --git-verify as the term --verify is too generic.
hutson
reviewed
Jul 18, 2018
| const args = ["commit", "--no-verify"]; | ||
| const args = ["commit"]; | ||
|
|
||
| if (opts && opts.noVerify) { |
There was a problem hiding this comment.
Shouldn't this default to --no-verify, and only remove --no-verify if opts.verify is set?
There was a problem hiding this comment.
Never mind. I see how you set noVerify below with the check for verify.
Some setups (e.g. Gerrit) require commit hooks that add a change id. So that lerna publish can properly push the commit in these environments, the `--no-verify` commit flag should not be specified. This adds a new flag `git-verify`, that if set to `true` will run the commit command without that option, so that all hooks are run.
8 tasks
evocateur
added a commit
that referenced
this pull request
Jul 27, 2018
BREAKING CHANGE: * `--preid` now defaults to "alpha" during prereleases: The previous default for this option was undefined, which led to an awkward "1.0.1-0" result when passed to `semver.inc()`. The new default "alpha" yields a much more useful "1.0.1-alpha.0" result. Any previous prerelease ID will be preserved, just as it was before. * `--no-verify` is no longer passed to `git commit` by default, but controlled by the new `--commit-hooks` option: The previous behavior was too overzealous, and the new option operates exactly like the corresponding [npm version](https://docs.npmjs.com/cli/version#commit-hooks) option of the same name. As long as your pre-commit hooks are properly scoped to ignore changes in package.json files, this change should not affect you. If that is not the case, you may pass `--no-commit-hooks` to restore the previous behavior. Fixes #277 Fixes #936 Fixes #956 Fixes #961 Fixes #1056 Fixes #1118 Fixes #1385 Fixes #1483 Fixes #1494
This was referenced Aug 10, 2018
nicolo-ribaudo
pushed a commit
to babel/lerna
that referenced
this pull request
Dec 18, 2018
BREAKING CHANGE: * `--preid` now defaults to "alpha" during prereleases: The previous default for this option was undefined, which led to an awkward "1.0.1-0" result when passed to `semver.inc()`. The new default "alpha" yields a much more useful "1.0.1-alpha.0" result. Any previous prerelease ID will be preserved, just as it was before. * `--no-verify` is no longer passed to `git commit` by default, but controlled by the new `--commit-hooks` option: The previous behavior was too overzealous, and the new option operates exactly like the corresponding [npm version](https://docs.npmjs.com/cli/version#commit-hooks) option of the same name. As long as your pre-commit hooks are properly scoped to ignore changes in package.json files, this change should not affect you. If that is not the case, you may pass `--no-commit-hooks` to restore the previous behavior. Fixes lerna#277 Fixes lerna#936 Fixes lerna#956 Fixes lerna#961 Fixes lerna#1056 Fixes lerna#1118 Fixes lerna#1385 Fixes lerna#1483 Fixes lerna#1494
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some setups (e.g. Gerrit) require commit hooks that add a change id.
So that lerna publish can properly push the commit in these
environments, the
--no-verifycommit flag should not be specified.This adds a new flag
verify, that if set totruewill run the commitcommand without thta option, so that all hooks are run.
Motivation and Context
lerna publish does not work in Gerrit environments
How Has This Been Tested?
Types of changes
Checklist: