Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package.json updates during publish #744

merged 12 commits into from Apr 7, 2017


Copy link


Object.prototype.toJSON() is normally called when passed to JSON.stringify(), but write-pkg iterates Object.keys() (to sort dependencies) before serializing so it has to be explicitly called here (otherwise it mangles the instance properties).

Motivation and Context

Fixes #741

How Has This Been Tested?

Added lerna publish integration tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)


  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evocateur evocateur added this to the v2.0.0 milestone Apr 7, 2017
@evocateur evocateur merged commit ad7e214 into lerna:master Apr 7, 2017
@evocateur evocateur deleted the fix-publish-json branch April 7, 2017 20:56
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

lerna publish inserts _package into package.json
1 participant