Fix package.json updates during publish #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 7, 2017 12:31
Object.prototype.toJSON() is normally called when passed to JSON.stringify(), but write-pkg iterates Object.keys() before serializing so it has to be explicitly called here (otherwise it mangles the instance properties). Fixes lerna#741
added 2 commits
April 7, 2017 13:10
… what the hell is wrong with windows
evocateur
force-pushed
the
fix-publish-json
branch
from
0cee1b5
to
25e9f7c
Compare
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Object.prototype.toJSON()is normally called when passed toJSON.stringify(), butwrite-pkgiteratesObject.keys()(to sort dependencies) before serializing so it has to be explicitly called here (otherwise it mangles the instance properties).Motivation and Context
Fixes #741
How Has This Been Tested?
Added
lerna publishintegration tests.Types of changes
Checklist: