fix(modal): always emit modal:hide #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 415 415
=====================================
Hits 415 415
Continue to review full report at Codecov.
|
willamesoares
approved these changes
Nov 29, 2017
fabricionaweb
approved these changes
Nov 29, 2017
willamesoares
force-pushed
the
fix/always-emit-modal-hide-event
branch
from
f715a07
to
881cacb
Compare
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 415 415
=====================================
Hits 415 415
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On show method, we always emit
modal:showbut in hide method we just emit this event when history feature is enabled. This pr makes hide methodo always emitmodal:hide